Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on signal() function #2813

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

matt335672
Copy link
Member

@matt335672 matt335672 commented Oct 2, 2023

Replaces uses of signal() with sigaction() which should be far more portable.

Tested on Linux and FreeBSD. See also #2811

sigaction() has been in POSIX since 2001, so I've not felt it necessary to add any feature tests for this.

@mstone2001 - this should solve a lot of your System-V issues I hope. Please review if you have the time.

Edit: I've added unit tests for the signal functions now, as these will be very useful in tracking down any odd behaviour in #2811 and maybe others

Replaces uses of signal() with sigaction() which should be far
more portable.
@matt335672
Copy link
Member Author

I'm merging this now, as the tests pass on Linux, FreeBSD and even OpenIndiana

@matt335672 matt335672 merged commit 93dfc18 into neutrinolabs:devel Oct 9, 2023
13 checks passed
@matt335672 matt335672 deleted the remove_signal_call branch October 9, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant